Skip to content

Declare types for node builtin modules in REPL so you do not need to import them #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2021
Merged

Declare types for node builtin modules in REPL so you do not need to import them #1500

merged 3 commits into from
Oct 10, 2021

Conversation

@cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Oct 10, 2021

Resolves #1424

@cspotcode cspotcode added this to the 10.3.0 milestone Oct 10, 2021
@codecov
Copy link

codecov bot commented Oct 10, 2021 •
edited
Loading

Codecov Report

Merging #1500 (c34588e) into main (4a0db31) will decrease coverage by 0.10%.
The diff coverage is 87.50%.

Impacted Files Coverage Δ
src/index.ts 77.83% <75.00%> (+0.27%) ⬆️
src/repl.ts 82.75% <100.00%> (+0.34%) ⬆️
src/esm.ts 84.21% <0.00%> (-3.93%) ⬇️
dist-raw/node-esm-default-get-format.js 71.42% <0.00%> (ø)
dist-raw/node-package-json-reader.js 88.88% <0.00%> (+5.55%) ⬆️

@cspotcode cspotcode merged commit 86c5d6e into main Oct 10, 2021
@cspotcode cspotcode deleted the declare-types-for-node-builtins-in-repl branch October 11, 2021 03:45
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@cspotcode cspotcode mentioned this pull request Nov 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

10.3.0

Development

Successfully merging this pull request may close these issues.

Declare types for node builtins modules within REPL virtual file

2 participants

@cspotcode