Refactor tests and bump TS version #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVA macros ended up being confusing for our use-cases, at least in my opinion: plain functions are clearer. But using
.context()is working well, so refactoring uses that more; places things on context instead of letting them sit in suite-local scope.Splits tests into multiple
.spec.tsfiles. The goal is to be easier to read and navigate tests.Splitting into multiple .spec files increases concurrency; taxes GH Actions more; causes timing issues. So I've made changes to REPL tests to have longer timeouts but to end early when expected patterns are detected on stdout/stderr.