Skip to content

fix: add more detailed error messages #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2025
Merged

fix: add more detailed error messages #1665

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1791dd
fix: add more detailed error messages
hai-x Jan 11, 2025
f6c15a7
chore: meta
hai-x Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/instances.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ export function initializeInstance(
} else {
if (!loader._compiler!.hooks) {
throw new Error(
"You may be using an old version of webpack; please check you're using at least version 4"
"You may be using an old version of webpack; please check you're using at least version 4. Or you should set `transpileOnly` or `happyPackMode` to true when using with `thread-loader`."
);
}

Expand Down
1 change: 0 additions & 1 deletion src/servicesHost.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,6 @@ function createWatchFactory(
}
return result;
}
``;
Copy link
Contributor Author

@hai-x hai-x Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small fix.

Copy link
Member

@johnnyreilly johnnyreilly Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!


function invokeRecursiveDirectoryWatcher(
directory: string,
Expand Down
Loading