Optimize fileExists callback path #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of looking up filePathKey twice, cache in in the local scope. This isn't a hugely expensive lookup path, but is a hot path on large project recompiles (especially after caches are blown away). Profiling shows that even the Map lookup shows non-trivial cache lookup aggregate time
Member
|
looks good! Can you update the |
Contributor
Author
|
@johnnyreilly - any idea what's up with the travis test failure? It was clean before I bumped package.json & I don't see any reason why my change should cause the listed failure Edit: Looks like I'm not the only failure on this https://travis-ci.org/github/TypeStrong/ts-loader/jobs/762060860 |
Member
|
travis has been flaky for a while and I want to remove it entirely - can't find the relevant setting in GitHub alas. It's intentionally not required so don''t worry. |
Member
This was referenced Mar 11, 2021
chore(deps): bump ts-loader from 6.2.2 to 8.0.18 in /OngekiScoreLog
project-primera/ongeki-score#357
Closed
Merged
Merged
Merged
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of looking up filePathKey twice, cache in in the local scope. This isn't a hugely expensive lookup path, but is a hot path on large project recompiles (especially after caches are blown away). Profiling shows that even the Map lookup shows non-trivial cache lookup aggregate time. (Less than a non-cached implementation though :) )
