-
Notifications
You must be signed in to change notification settings - Fork 9
feat: Support using LoadBalancer service hostname as proxy address
#690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support using LoadBalancer service hostname as proxy address
#690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances service handling by supporting the use of a LoadBalancer service hostname as a fallback when an IP address is unavailable.
- Introduces a new function, get_load_balancer_external_ip, that returns either the IP or the hostname from the ingress.
- Updates test cases to verify the behavior for both IP and hostname scenarios.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/handlers/tests/test_handlers_services.py | Updates tests to support both IP and hostname scenarios for LoadBalancer services. |
| app/handlers/handlers_services.py | Refactors the load balancer validation and retrieval logic to support hostname fallback. |
Comments suppressed due to low confidence (1)
app/handlers/handlers_services.py:83
- The error message raised below still refers to 'LoadBalancer IP is not ready', which might be misleading since a hostname is also acceptable. Consider updating the error message to reflect that a valid LoadBalancer external address (IP or hostname) is required.
if not ip and not hostname:
Pull Request Test Coverage Report for Build 15703856838Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
minhtule
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix & merge!
Bumps [pytest-randomly](https://github.com/pytest-dev/pytest-randomly) from 3.16.0 to 4.0.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-randomly/blob/main/CHANGELOG.rst">pytest-randomly's changelog</a>.</em></p> <blockquote> <h2>4.0.1 (2025-09-12)</h2> <ul> <li> <p>Remove the random state caching, which would grow without bound, leaking memory in long test runs. The caching was added to slightly speed up re-using the same (final) seed, but since the final seed is now different for each test, it has no effect.</p> <p><code>PR [#690](pytest-dev/pytest-randomly#690) <https://github.com/pytest-dev/pytest-randomly/issues/687></code>__.</p> </li> <li> <p>Modify Numpy seed restriction, replacing hashing with a modulo operation. The extra work to hash is unnecessary now that we generate a final seed per test with CRC32. This change saves ~500ns per test when Numpy is installed.</p> <p><code>PR [#691](pytest-dev/pytest-randomly#691) <https://github.com/pytest-dev/pytest-randomly/issues/691></code>__.</p> </li> </ul> <h2>4.0.0 (2025-09-10)</h2> <ul> <li> <p>Support Python 3.14.</p> </li> <li> <p>Use a different random seed per test, based on the test ID.</p> <p>This change should mean that tests exercise more random data values in a given run, and that any randomly-generated identifiers have a lower chance of collision when stored in a shared resource like a database.</p> <p><code>PR [#687](pytest-dev/pytest-randomly#687) <https://github.com/pytest-dev/pytest-randomly/issues/687></code><strong>. Thanks to Bryce Drennan for the suggestion in <code>Issue [#600](pytest-dev/pytest-randomly#600) <https://github.com/pytest-dev/pytest-randomly/issues/600></code></strong> and initial implementation in <code>PR [#617](pytest-dev/pytest-randomly#617) <https://github.com/pytest-dev/pytest-randomly/pull/617></code>__.</p> </li> <li> <p>Move from MD5 to CRC32 for hashing test IDs, as it’s 5x faster and we don’t need cryptographic security.</p> <p><code>Issue [#686](pytest-dev/pytest-randomly#686) <https://github.com/pytest-dev/pytest-randomly/issues/686></code>__.</p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pytest-dev/pytest-randomly/commit/50de0961ad3479901a153a4a89ff58ca7898b550"><code>50de096</code></a> Version 4.0.1</li> <li><a href="https://github.com/pytest-dev/pytest-randomly/commit/f9406ec4452d05a865ee67b83fed58bc8f914bac"><code>f9406ec</code></a> Modify Numpy seed restriction (<a href="https://redirect.github.com/pytest-dev/pytest-randomly/issues/691">#691</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-randomly/commit/22049aabcd1e19012c878dccd5fb1ad728221331"><code>22049aa</code></a> Remove the random state caching (<a href="https://redirect.github.com/pytest-dev/pytest-randomly/issues/690">#690</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-randomly/commit/ded2e547566368d8751a13bf6b6e6ac8b509caa2"><code>ded2e54</code></a> Version 4.0.0</li> <li><a href="https://github.com/pytest-dev/pytest-randomly/commit/cb9b86128c9e79284f1bfad0dbd5d4c5427b5dfc"><code>cb9b861</code></a> Move from MD5 to CRC32 for hashing test IDs (<a href="https://redirect.github.com/pytest-dev/pytest-randomly/issues/688">#688</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-randomly/commit/bd697bd670943c54b8d21e713dea58ab92508d08"><code>bd697bd</code></a> Use a different random seed per test (<a href="https://redirect.github.com/pytest-dev/pytest-randomly/issues/687">#687</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-randomly/commit/acadf4684fd12e5e9ca14243167f44b8d302f093"><code>acadf46</code></a> Generate default seed on demand (<a href="https://redirect.github.com/pytest-dev/pytest-randomly/issues/685">#685</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-randomly/commit/f818056fa7933f9f08ff6c5cda0d78ecee14d0af"><code>f818056</code></a> Support Python 3.14 (<a href="https://redirect.github.com/pytest-dev/pytest-randomly/issues/684">#684</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-randomly/commit/456f7877992809b4e152bf3a356c0a4658275fb7"><code>456f787</code></a> Drop unused import of xdist</li> <li><a href="https://github.com/pytest-dev/pytest-randomly/commit/e00b7822dff8061d26ff2b4bdf9dc1a3ea823092"><code>e00b782</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-randomly/issues/682">#682</a>)</li> <li>Additional commits viewable in <a href="https://github.com/pytest-dev/pytest-randomly/compare/3.16.0...4.0.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Changes
LoadBalancerservice hostname as proxy address ifipis not availableNotes
Some Cloud providers' (E.g. AWS)
LoadBalancerservice does not have theipfield in thestatus.loadBalancer.ingress[0]object.