Skip to content

Conversation

@ptgamr
Copy link

@ptgamr ptgamr commented Jun 2, 2025

Related issue

#17

Updated 2025-06-11

This MR should be now ready for review.

I have tidied up the code and move the relevant parts to here.

Have it working with soccernet sn-gamestate with some minimal changes: https://github.com/ptgamr/sn-gamestate/commits/online-tracking/ . I added soccernet_online.yaml to have the online tracking pipeline, comment out parts that aren't compatible (ie. those VideoLevelModule). Run it via following cmd:

uv run tracklab -cn soccernet_online

I am unsure how to change the code so that I don't need to change this in sn-gamestate

image

This is a demo video:

Peek.2025-06-11.00-14.webm

@bstandaert
Copy link
Member

We need to clean the printings and test the PR. Thank you for your contribution.

@bstandaert bstandaert requested a review from victorjoos June 6, 2025 08:31
@ptgamr ptgamr marked this pull request as draft June 6, 2025 10:37
@ptgamr
Copy link
Author

ptgamr commented Jun 6, 2025

Sorry @bstandaert , I must have created this PR by mistake some how - it is still very much experimental from my end, not ready to merge yet... I changed it to draft for now...

@ptgamr ptgamr changed the title fix to support online tracking Support online tracking Jun 6, 2025
@ptgamr
Copy link
Author

ptgamr commented Jun 6, 2025

Also, @bstandaert - how should I test the PR?

I have it kinda working with sn-gamestate challenge.. but I have to commented out these module... perhaps because they're VideoLevelModule and it's not suitable with ONLINE?

  # - modules/team: kmeans_embeddings
  # - modules/team_side: mean_position
  # - modules/tracklet_agg: voting_role_jn

Here is the branch if you're interested: https://github.com/ptgamr/sn-gamestate/commits/online-tracking/ (I've have some difficulty showing some GUI because both open-cv and open-cv-headless both installed, I have to remove open-cv-headless)

@ptgamr
Copy link
Author

ptgamr commented Jun 6, 2025

Aso, I think I need to move this custom "visualization engine" I wrote to this repo:

https://github.com/ptgamr/sn-gamestate/blob/online-tracking/sn_gamestate/visualization/online_visualization_engine.py

@victorjoos
Copy link
Contributor

You're right, the VideoLevelModule is not compatible with online tracking. The best thing would probably be to display a clear error to the user when there are VideoLevelModules and you want to do online tracking.

For testing, you should make sure it works with the default video, and the default config (except for using the online engine in place of the offline engine). You can go further by checking everything works with the defaults of sn-gamestate (as you've already done) and CAMELTrack.

@ptgamr ptgamr force-pushed the online-tracking branch 2 times, most recently from 99b8918 to 7244fb7 Compare June 10, 2025 12:15
@ptgamr ptgamr marked this pull request as ready for review June 10, 2025 12:15
@ptgamr
Copy link
Author

ptgamr commented Jun 10, 2025

@bstandaert @victorjoos I have tidy up the MR and would love to have a review from you guys.

Cheers,
Anh

@ptgamr ptgamr force-pushed the online-tracking branch from 7244fb7 to 2ed10ac Compare June 10, 2025 12:49
@victorjoos
Copy link
Contributor

Hi @ptgamr,

I'm sorry this takes so much time, I just started a new job, so don't have too much bandwidth for this right now.

I'll try to look into this on Friday.

@ptgamr
Copy link
Author

ptgamr commented Jul 9, 2025

@victorjoos I hope you are setting in with your new job. Just want to give this a nudge, as it is still fresh in my mind so I can address thing quickly if needed be.

@ptgamr ptgamr force-pushed the online-tracking branch from b87fbc7 to 0c59d39 Compare July 10, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants