-
Notifications
You must be signed in to change notification settings - Fork 29
Support online tracking #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
We need to clean the printings and test the PR. Thank you for your contribution. |
|
Sorry @bstandaert , I must have created this PR by mistake some how - it is still very much experimental from my end, not ready to merge yet... I changed it to draft for now... |
|
Also, @bstandaert - how should I test the PR? I have it kinda working with Here is the branch if you're interested: https://github.com/ptgamr/sn-gamestate/commits/online-tracking/ (I've have some difficulty showing some GUI because both |
|
Aso, I think I need to move this custom "visualization engine" I wrote to this repo: |
|
You're right, the VideoLevelModule is not compatible with online tracking. The best thing would probably be to display a clear error to the user when there are VideoLevelModules and you want to do online tracking. For testing, you should make sure it works with the default video, and the default config (except for using the online engine in place of the offline engine). You can go further by checking everything works with the defaults of sn-gamestate (as you've already done) and CAMELTrack. |
99b8918 to
7244fb7
Compare
|
@bstandaert @victorjoos I have tidy up the MR and would love to have a review from you guys. Cheers, |
|
Hi @ptgamr, I'm sorry this takes so much time, I just started a new job, so don't have too much bandwidth for this right now. I'll try to look into this on Friday. |
|
@victorjoos I hope you are setting in with your new job. Just want to give this a nudge, as it is still fresh in my mind so I can address thing quickly if needed be. |
Related issue
#17
Updated 2025-06-11
This MR should be now ready for review.
I have tidied up the code and move the relevant parts to here.
Have it working with soccernet
sn-gamestatewith some minimal changes: https://github.com/ptgamr/sn-gamestate/commits/online-tracking/ . I addedsoccernet_online.yamlto have the online tracking pipeline, comment out parts that aren't compatible (ie. thoseVideoLevelModule). Run it via following cmd:I am unsure how to change the code so that I don't need to change this in
sn-gamestateThis is a demo video:
Peek.2025-06-11.00-14.webm