-
Couldn't load subscription status.
- Fork 59
Big breaking API redesign #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
006c573
8d585bb
8480fee
b6f50c7
49be107
b1dc332
38befe2
4059d36
d18cd80
a078d44
bd55620
7a4be59
691bad3
25c633f
5566668
de1498e
20634b8
58aa8f6
7e824b7
6bc02da
eb150de
c72febd
3526569
e6996e2
fc25199
b15ccce
1206cdd
81739aa
7f42382
1fd7721
a4d3686
3be3c0f
8618a7d
b1e3ced
5dc082e
534fecd
de6edc1
97abba5
b974edd
9dbd05b
a26a1bb
077218b
2954183
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,14 +2,6 @@ | |
|
|
||
| TorchSim is an experimental library and we would appreciate any feedback from the community. | ||
|
|
||
| ## Contributor License Agreement (CLA) | ||
|
|
||
| Before contributing, you'll need to sign our Contributor License Agreement (CLA). This is a one-time requirement that covers all Radical AI open source projects. The CLA allows you to maintain ownership of your contributions while granting Radical AI the necessary rights to use them. | ||
|
|
||
| [Radical AI CLA](https://www.radical-ai.com/oss) | ||
|
|
||
| Our CLA-bot will automatically verify your signature on pull requests. For questions about the CLA, contact [email protected]. | ||
|
|
||
| ## Code Reviews | ||
|
|
||
| All submissions require review by project maintainers before merging: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| # TorchSim | ||
|
|
||
| [](https://github.com/TorchSim/torch-sim/actions/workflows/test.yml) | ||
| [](https://codecov.io/gh/radical-ai/torch-sim) | ||
| [](https://python.org/downloads) | ||
| [](https://pypi.org/project/torch_sim_atomistic) | ||
| [](https://github.com/torchsim/torch-sim/actions/workflows/test.yml) | ||
| [](https://codecov.io/gh/torchsim/torch-sim) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://codecov.io/gh/torchsim/torch-sim is a broken link currently There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tried adding codecov app to this new org. seems to have worked but then but it's not showing up for me in the web UI (yet)... |
||
| [](https://python.org/downloads) | ||
| [](https://pypi.org/project/torch-sim-atomistic) | ||
| [][zenodo] | ||
|
|
||
| [zenodo]: https://zenodo.org/records/15127004 | ||
|
|
@@ -81,27 +81,14 @@ To then relax those structures with FIRE is just a few more lines. | |
| relaxed_state = ts.optimize( | ||
| system=final_state, | ||
| model=mace_model, | ||
| optimizer=ts.frechet_cell_fire, | ||
| optimizer=ts.OptimFlavor.fire, | ||
| cell_filter=ts.CellFilter.frechet, | ||
|
||
| autobatcher=True, | ||
| ) | ||
|
|
||
| print(relaxed_state.energy) | ||
| ``` | ||
|
|
||
| ## Speedup | ||
|
|
||
| TorchSim achieves up to 100x speedup compared to ASE with popular MLIPs. | ||
|
|
||
| <img src="/docs/_static/speedup_plot.svg" alt="Speedup comparison" width="100%"> | ||
|
|
||
| This figure compares the time per atom of ASE and `torch_sim`. Time per atom is defined | ||
| as the number of atoms / total time. While ASE can only run a single system of `n_atoms` | ||
| (on the $x$ axis), `torch_sim` can run as many systems as will fit in memory. On an H100 80 GB card, | ||
| the max atoms that could fit in memory was ~8,000 for [EGIP](https://github.com/FAIR-Chem/fairchem), | ||
| ~10,000 for [MACE-MPA-0](https://github.com/ACEsuit/mace), ~22,000 for [Mattersim V1 1M](https://github.com/microsoft/mattersim), | ||
| ~2,500 for [SevenNet](https://github.com/MDIL-SNU/SevenNet), and ~9000 for [PET-MAD](https://github.com/lab-cosmo/pet-mad). | ||
| This metric describes model performance by capturing speed and memory usage simultaneously. | ||
orionarcher marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ## Installation | ||
|
|
||
| ### PyPI Installation | ||
|
|
@@ -113,7 +100,7 @@ pip install torch-sim-atomistic | |
| ### Installing from source | ||
|
|
||
| ```sh | ||
| git clone https://github.com/TorchSim/torch-sim | ||
| git clone https://github.com/torchsim/torch-sim | ||
| cd torch-sim | ||
| pip install . | ||
| ``` | ||
|
|
@@ -126,11 +113,11 @@ To understand how TorchSim works, start with the [comprehensive tutorials](https | |
|
|
||
| TorchSim's package structure is summarized in the [API reference](https://torchsim.github.io/torch-sim/reference/index.html) documentation and drawn as a treemap below. | ||
|
|
||
|  | ||
|  | ||
|
|
||
| ## License | ||
|
|
||
| TorchSim is released under an [MIT license](LICENSE). | ||
| TorchSim is released under an [MIT license](license). | ||
|
|
||
| ## Citation | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the ability to clickthrough, why change it? Could at least make these hyperlinks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to use hyperlinks like in release notes