Skip to content

Conversation

@YutackPark
Copy link
Contributor

@YutackPark YutackPark commented Apr 23, 2025

Summary

Include a summary of major changes in bullet points:

  • Fix 1: torch.dtype == torch.float32 to dtype == torch.float32
  • Change 1: raise ValueError if type_map is None. The switch is introduced due to historical reason and should be True.

Checklist

Before a pull request can be merged, the following items must be checked:

  • Doc strings have been added in the Google docstring format.
    Run ruff on your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

@cla-bot cla-bot bot added the cla-signed Contributor license agreement signed label Apr 23, 2025
@orionarcher
Copy link
Collaborator

Thanks for the update @YutackPark! Ready to merge?

@YutackPark
Copy link
Contributor Author

Sure!

@CompRhys CompRhys merged commit d2cee66 into TorchSim:main Apr 24, 2025
90 checks passed
@janosh janosh added fix Bug fix models Model-related issues and PRs labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor license agreement signed fix Bug fix models Model-related issues and PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants