-
Couldn't load subscription status.
- Fork 56
Add MatterSim and fix ASE cell convention issues. #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ix orb for non-cubic cells, add roundtrip io tests, test models on variety of structures,
…id memory on autobatch test
|
|
||
| half_supercell = ( | ||
| torch.max(state.volume) > 1000 | ||
| torch.max(torch.det(state.cell)) > 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is because volume isn't defined for PBC=False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also won't be defined for PBC=False because state.cell will be None.
What about:
half_supercell = (
torch.max(state.volume) > 1000
if state.pbc and self._half_supercell is None
else self._half_supercell
)…atched model to vesin_nl, change examples not to show nl choice by default, attempt to remove default dtype call in MACE so it's tests don't impact other tests (2 failures left)
…olumn vector convention for cell in SimState
…ansposes needed to match ASE conventions baked into models.
…echet optimizers accordingly
…ter test batched frechet.
Reverts to use original SevenNet neighbor list based on covariate discussion with @AdeeshKolluru (c.f. mattersim neighbor list comment).