-
Notifications
You must be signed in to change notification settings - Fork 56
add pip required & optional dependencies #2118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a486a6 to
668bc0c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Requires `pip>25.0.1`. See also: - https://peps.python.org/pep-0735/ - pypa/pip#13065 - #2118 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and approve this since it looks like a fairly good first step.
I'm a bit worried about the duplicated dependencies everywhere, but that can be fixed incrementally!
Requires `pip>25.0.1`. See also: - https://peps.python.org/pep-0735/ - pypa/pip#13065 - #2118 (comment)
6b6d567 to
6c87531
Compare
Requires `pip>25.0.1`. See also: - https://peps.python.org/pep-0735/ - pypa/pip#13065 - #2118 (comment)
6c87531 to
87d02f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TL;DR: moving towards being able to
pip install cil[gpu],pip install . --group test, etc.zenodo_getdependency and unit test errors #2074 (related: Remove change ofImportErrormessage for optional dependencies #2104)--groupoption for installing from[dependency-groups]found inpyproject.tomlfiles pypa/pip#13065 being released inpip>25.0.1Testing
pip install "cil[gpu]@git+https://github.com/TomographicImaging/CIL@pyproject-deps"should say "Requirement already satisfied" for everything.Documentation
This PR is a stepping stone (and also will only become fully useful after the next
piprelease). Docs will be tackled later in #1875.