Skip to content

Conversation

@casperdcl
Copy link
Member

@casperdcl casperdcl commented Mar 26, 2025

TL;DR: moving towards being able to pip install cil[gpu], pip install . --group test, etc.

Testing

  1. setup a CIL build environment normally as per the current README
  2. pip install "cil[gpu]@git+https://github.com/TomographicImaging/CIL@pyproject-deps" should say "Requirement already satisfied" for everything.

Documentation

This PR is a stepping stone (and also will only become fully useful after the next pip release). Docs will be tackled later in #1875.

@casperdcl casperdcl mentioned this pull request Mar 26, 2025
14 tasks
@casperdcl casperdcl force-pushed the pyproject-deps branch 2 times, most recently from 6a486a6 to 668bc0c Compare March 26, 2025 11:01
@purepani

This comment was marked as resolved.

casperdcl added a commit that referenced this pull request Mar 26, 2025
Copy link
Collaborator

@purepani purepani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and approve this since it looks like a fairly good first step.
I'm a bit worried about the duplicated dependencies everywhere, but that can be fixed incrementally!

@purepani purepani self-requested a review March 28, 2025 16:39
casperdcl added a commit that referenced this pull request Apr 1, 2025
Copy link
Collaborator

@purepani purepani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casperdcl casperdcl merged commit e2878f3 into master Apr 17, 2025
10 checks passed
@casperdcl casperdcl deleted the pyproject-deps branch April 17, 2025 12:28
@github-project-automation github-project-automation bot moved this from Priority review to Done in CIL work Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

pyproject dependencies zenodo_get dependency and unit test errors

4 participants