Refactor #1
Merged
Refactor #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into separate methods and regrouped data accordingly into new tuples. Replaced some comments with samely named method calls. Prefixed some booleans with "is_" for better readability. Reorganized imports. Marked some initialization code that seems dead and added a few TODOs for further consideration and optimization.
… vars to avoid reassignments and consolidate calls.
…oper initialization.
…new module in dedicated package.
… package to render_data because, really it's all just data.
…ce side effects and to limit scopes.
… isolate and group side effects. More stuff moved to static context.
…d renamed the render package to avoid conflicts and confusion with the render module.
…d stuff and added more TODOs.
…on a button-click in PyCharm (Interpreter path pointing to standard Windows powershell dir by default, all other paths provided relative).
… prepare for reduction of complexities in method calls. render_animation method torn appart to ensure tightly scoped args and also unfroze the AnimationMode class again to allow for the late initialization of prev_flow for now.
…s that broke in the last commit. All original arguments have been taken out of scope for now. More TODOs added.
…uggled some bools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started to refactor render.py