Skip to content

fix auto align #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix auto align #166

wants to merge 2 commits into from

Conversation

@k1rxz
Copy link

@k1rxz k1rxz commented Sep 19, 2025

this was the stupidest pull request i've ever seen

@k1rxz k1rxz added this to the States milestone Sep 19, 2025
@k1rxz k1rxz requested a review from Abigail-27 September 19, 2025 21:16
@k1rxz k1rxz added bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested wontfix This will not be worked on low priority low priority task needs robot for testing regular priority normal priority item backlog item currently on the backlog of stuff to do high priority extremely important stuff that NEEDS to get done sim testing Should be tested using simulation as a first step wishful thinking this issue is wishful thinking do not merge (yet) this is a joke this issue is a joke, dw about it this is not a joke minion task offseason idea labels Sep 19, 2025
@Ishan1522
Copy link
Member

Ishan1522 commented Sep 22, 2025

/format

Ishan1522
Ishan1522 reviewed Sep 22, 2025
View reviewed changes
src/main/java/frc/robot/Robot.java Outdated

driverController.leftTrigger()
.whileTrue(
new InstantCommand(() -> swerveDrive.resetEstimatedPose(visionSubsystem.getLastSeenPose())).andThen(
Copy link
Member

@Ishan1522 Ishan1522 Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the camera doesn't see an april tag? Does it still work? Has it been tested? Are we not manually resetting it? Also, you currently have two Auto align (left reef) bound to the same trigger. (Scroll up in the method. It's under the set default command)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ishan1522 Ishan1522 Ishan1522 left review comments

@JacksonElia JacksonElia JacksonElia approved these changes

@Abigail-27 Abigail-27 Awaiting requested review from Abigail-27

Assignees

No one assigned

Labels

backlog item currently on the backlog of stuff to do bug Something isn't working do not merge (yet) documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed high priority extremely important stuff that NEEDS to get done invalid This doesn't seem right low priority low priority task minion task needs robot for testing offseason idea question Further information is requested regular priority normal priority item sim testing Should be tested using simulation as a first step this is a joke this issue is a joke, dw about it this is not a joke wishful thinking this issue is wishful thinking wontfix This will not be worked on

Projects

None yet

Milestone

States

Development

Successfully merging this pull request may close these issues.

4 participants

@k1rxz @Ishan1522 @JacksonElia