Skip to content

🔨 Add mypy Checks #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 22, 2023
Merged

🔨 Add mypy Checks #740

merged 14 commits into from
Nov 22, 2023

Conversation

@Jiaqi-Lv
Copy link
Collaborator

@Jiaqi-Lv Jiaqi-Lv commented Nov 17, 2023 •
edited
Loading

Files added:

  • tiatoolbox/utils/exceptions.py
  • tiatoolbox/utils/magic.py
  • tiatoolbox/utils/metrics.py
  • tiatoolbox/utils/transforms.py
  • tiatoolbox/tiatoolbox.py

@Jiaqi-Lv Jiaqi-Lv self-assigned this Nov 17, 2023
@Jiaqi-Lv Jiaqi-Lv marked this pull request as ready for review November 17, 2023 12:34
@Jiaqi-Lv Jiaqi-Lv requested a review from shaneahmed November 17, 2023 12:35
shaneahmed
shaneahmed reviewed Nov 17, 2023
View reviewed changes
@shaneahmed shaneahmed added this to the Release v1.5.0 milestone Nov 17, 2023
@shaneahmed shaneahmed changed the title 🔨 Add more files to mypy 🔨 Add files to mypy check Nov 17, 2023
@shaneahmed shaneahmed added the dev tools Changes/Updates in Development tools label Nov 17, 2023
shaneahmed
shaneahmed reviewed Nov 17, 2023
View reviewed changes
shaneahmed
shaneahmed reviewed Nov 17, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d3f039) 99.85% compared to head (d7d0450) 99.85%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #740   +/-   ##
========================================
  Coverage    99.85%   99.85%           
========================================
  Files           65       65           
  Lines         7520     7532   +12     
  Branches      1461     1461           
========================================
+ Hits          7509     7521   +12     
  Misses           4        4           
  Partials         7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jiaqi-Lv
Jiaqi-Lv commented Nov 17, 2023
View reviewed changes
@shaneahmed
Copy link
Member

shaneahmed commented Nov 17, 2023 •
edited
Loading

@Jiaqi-Lv Please can you fix the coverage? The if statement only covers once condition in tests. Try modifying the tests to cover this scenario.
https://app.codecov.io/gh/TissueImageAnalytics/tiatoolbox/pull/740/blob/tiatoolbox/utils/transforms.py#L110

shaneahmed
shaneahmed reviewed Nov 17, 2023
View reviewed changes
shaneahmed
shaneahmed reviewed Nov 17, 2023
View reviewed changes
@shaneahmed shaneahmed changed the title 🔨 Add files to mypy check 🔨 Add mypy Checks Nov 22, 2023
shaneahmed
shaneahmed approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiaqi-Lv

@shaneahmed shaneahmed merged commit 8e9545f into develop Nov 22, 2023
@shaneahmed shaneahmed deleted the dev-mypy-type-check branch November 22, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaneahmed shaneahmed shaneahmed approved these changes

Assignees

@Jiaqi-Lv Jiaqi-Lv

Labels

dev tools Changes/Updates in Development tools

Projects

None yet

Milestone

Release v1.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Jiaqi-Lv @shaneahmed