⬆️ Upgrade numpy Dependency
#543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- np.int is depreciated in v1.20
- np.int, np.bool, np.float is depreciated in v1.20
Codecov Report
@@ Coverage Diff @@
## develop #543 +/- ##
========================================
Coverage 99.74% 99.74%
========================================
Files 63 63
Lines 6744 6744
Branches 1107 1107
========================================
Hits 6727 6727
Misses 8 8
Partials 9 9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shaneahmed
changed the title
John-P
approved these changes
Mar 2, 2023
Contributor
|
Looks good but need to get numba/umap support. |
Member
Author
It's still a draft as numba is not yet compatible on Windows. |
shaneahmed
changed the title
numpy Dependency
shaneahmed
changed the title
numpy Dependencynumpy Dependency
# Conflicts: # tiatoolbox/wsicore/wsireader.py
- Add numba as dependency - Pin numba>=0.57.0
- Use `np.int_` as `np.int` is deprecated.
- VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences (which is a list-or-tuple of lists-or-tuples-or ndarrays with different lengths or shapes) is deprecated. If you meant to do this, you must specify 'dtype=object' when creating the ndarray.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on some dependencies to update:
numba not yet compatible with numpy 1.24
Waiting for next numba release with numpy 1.24 support.