Skip to content

Conversation

@John-P
Copy link
Contributor

@John-P John-P commented Oct 14, 2022

This PR fixes a bug where only the numerator of the TIFF resolution tags was being read.

@John-P John-P added the bug Something isn't working label Oct 14, 2022
@John-P John-P requested a review from shaneahmed October 14, 2022 12:38
@John-P John-P self-assigned this Oct 14, 2022
@John-P John-P changed the title Bug tiff resolution BUG: Read TIFF Resolution Tags As A Fraction Oct 14, 2022
@John-P John-P linked an issue Oct 14, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #489 (96dc1d3) into develop (bc5ee15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #489   +/-   ##
========================================
  Coverage    99.65%   99.65%           
========================================
  Files           61       61           
  Lines         6064     6064           
  Branches       995      995           
========================================
  Hits          6043     6043           
  Misses           9        9           
  Partials        12       12           
Impacted Files Coverage Δ
tiatoolbox/wsicore/wsireader.py 98.06% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks @John-P

@shaneahmed shaneahmed merged commit b0d5981 into develop Oct 14, 2022
@shaneahmed shaneahmed deleted the bug-tiff-resolution branch October 14, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image Resolution wrongly read in TIFFWSIReader

3 participants