Skip to content

Conversation

@DavidBAEpstein
Copy link
Collaborator

@DavidBAEpstein DavidBAEpstein commented Sep 3, 2022

Corrects a single typo in a python module

Copy link
Collaborator Author

@DavidBAEpstein DavidBAEpstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A one-character typo

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #458 (1e18ad7) into develop (fe1112f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #458   +/-   ##
========================================
  Coverage    98.63%   98.63%           
========================================
  Files           60       60           
  Lines         5916     5916           
  Branches      1053     1053           
========================================
  Hits          5835     5835           
  Misses          69       69           
  Partials        12       12           
Impacted Files Coverage Δ
tiatoolbox/models/engine/semantic_segmentor.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DavidBAEpstein DavidBAEpstein self-assigned this Sep 4, 2022
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DavidBAEpstein
There is a new pre-commit error. I will fix it in a separate PR.

@shaneahmed
Copy link
Member

Thanks @DavidBAEpstein There is a new pre-commit error. I will fix it in a separate PR.

@John-P I think PatchExtractor is not written as an abstract class. So we can remove the inheritance from it. Re dsl, this requires @abstractmethod decorators.

@shaneahmed shaneahmed merged commit 11b1e10 into develop Sep 5, 2022
@shaneahmed shaneahmed deleted the doc-typo branch September 5, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants