-
Notifications
You must be signed in to change notification settings - Fork 101
BUG: Update HoVer-Net+ Post-processing #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #431 +/- ##
========================================
Coverage 99.65% 99.65%
========================================
Files 61 61
Lines 6064 6082 +18
Branches 995 997 +2
========================================
+ Hits 6043 6061 +18
Misses 9 9
Partials 12 12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks good. Just a small note on performance, though. I think the cv2 equivalent operations might be a bit faster than the skimage ones. This is minor but could have a bigger impact on a WSI level. |
|
Looks good to me. I agree with John's comment on using opencv for morphological processing. |
Hi John, after looking at this I see that there are no opencv equivalents for the functions that I have used. I've also looked at the source code for these functions, and they rely on scipy anyway. Probably best to keep as it is? |
Fix an issue with the HoVer-Net+ post-processing. Previously, a simple blur was applied for the post-processing. Now it is updated inline with the original work - using various morphological operations specific to each epithelial layer.
Remove warnings from importing specific libraries in both HoVer-Net and HoVer-Net+.