-
Notifications
You must be signed in to change notification settings - Fork 101
ENH: On Demand Imports #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ghadjigeorghiou For a minimal set of requirements, I believe you could skip these:
Other libraries which could fairly easily be made to be imported on demand if desired:
|
Codecov Report
@@ Coverage Diff @@
## develop #222 +/- ##
========================================
Coverage 99.81% 99.81%
========================================
Files 53 53
Lines 4869 4870 +1
Branches 800 800
========================================
+ Hits 4860 4861 +1
Misses 2 2
Partials 7 7
Continue to review full report at Codecov.
|
|
I may leave this a just glymur / openjpeg for now, as that makes another non-pip dependency optional, which is nice. |
- Remove glymur settings before glymur import
- Fix develop requirements for python 3.7
# Conflicts: # requirements_dev.txt
shaneahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @John-P
The aim of this PR (which is a branch off of tidying wsireader.py) aims to make imports only happen as needed where possible. This means that some dependencies can be avoided if they are not required.
On demand imports so far: