DEV: Add Auxiliary Functionality For SlideGraph #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneahmed
reviewed
Dec 3, 2021
shaneahmed
reviewed
Dec 3, 2021
Member
shaneahmed
left a comment
shaneahmed
left a comment
There was a problem hiding this comment.
I only have one comment on this PR as mentioned in scale.py
For travis, can you try to PIN opencv to the previous version on which it passed? I think that might be the issue.
- Pin scikit-image for travis errors
- Pin scikit-image to 0.18.3 to fix travis errors
Codecov Report
@@ Coverage Diff @@
## develop #208 +/- ##
=========================================
Coverage 99.82% 99.83%
=========================================
Files 50 51 +1
Lines 4683 4792 +109
Branches 764 780 +16
=========================================
+ Hits 4675 4784 +109
Misses 2 2
Partials 6 6
Continue to review full report at Codecov.
|
shaneahmed
approved these changes
Dec 6, 2021
John-P
changed the title
Contributor
|
We now have some duplicate functionality to resolve. There is visualisation as part of the graph construction class and also another graph plotting function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate existing .py in #180 to another branch. Included functionalities are:
Generic graph plotting onto canvas
Plat Scaler for calibrating probabilities
Pin scikit-image to avoid errors due to changes in the updated version.
Add functionalities
Add tests