Skip to content

Conversation

@John-P
Copy link
Contributor

@John-P John-P commented Nov 26, 2021

A suggestion to in crease the cognitive complexity limit. The current threshold can be triggered by simple things such as a few ifs in a row, especially as python doesn't use switch statements. We also have two other complexity checks in place.

@John-P John-P added the dev tools Changes/Updates in Development tools label Nov 26, 2021
@John-P John-P requested review from shaneahmed and vqdang November 26, 2021 10:48
@John-P John-P changed the title DEV: Increase Cognitive Complexity Limit In setup [skip travis] DEV: Increase Cognitive Complexity Limit In setup Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #201 (9de5b38) into develop (87c83a2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #201   +/-   ##
========================================
  Coverage    99.82%   99.82%           
========================================
  Files           49       49           
  Lines         4598     4598           
  Branches       750      750           
========================================
  Hits          4590     4590           
  Misses           2        2           
  Partials         6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef490f...9de5b38. Read the comment docs.

@shaneahmed shaneahmed merged commit 03f25a9 into develop Nov 26, 2021
@shaneahmed shaneahmed deleted the dev-cognative-complexity-thresh branch November 26, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev tools Changes/Updates in Development tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants