Skip to content

Conversation

@simongraham
Copy link
Contributor

Change class names to fit in line with the rest of the API. Namely, we change:

  • CNNPatchPredictor -> PatchPredictor
  • StainAugmentation -> StainAugmentor

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@shaneahmed shaneahmed changed the title ENH: Change CNNPatchPredictor to PatchPredictor and StainAugmentation to StainAugmentor API: Change CNNPatchPredictor to PatchPredictor and StainAugmentation to StainAugmentor Nov 22, 2021
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simongraham

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #197 (362357a) into develop (d98e091) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #197      +/-   ##
===========================================
+ Coverage    99.77%   99.79%   +0.01%     
===========================================
  Files           45       47       +2     
  Lines         3572     3909     +337     
  Branches       577      646      +69     
===========================================
+ Hits          3564     3901     +337     
  Misses           2        2              
  Partials         6        6              
Impacted Files Coverage Δ
tiatoolbox/models/__init__.py 100.00% <ø> (ø)
tiatoolbox/cli/patch_predictor.py 100.00% <100.00%> (ø)
tiatoolbox/models/engine/patch_predictor.py 100.00% <100.00%> (ø)
tiatoolbox/tools/stainaugment.py 100.00% <100.00%> (ø)
tiatoolbox/utils/image.py 100.00% <0.00%> (ø)
tiatoolbox/utils/transforms.py 100.00% <0.00%> (ø)
tiatoolbox/tools/pyramid.py 100.00% <0.00%> (ø)
tiatoolbox/tools/graph.py 100.00% <0.00%> (ø)
tiatoolbox/wsicore/wsireader.py 99.31% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98e091...362357a. Read the comment docs.

@shaneahmed shaneahmed merged commit 7e2bd00 into develop Nov 24, 2021
@shaneahmed shaneahmed deleted the enhance-change-classnames branch November 24, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants