NEW: Add Feature HoVerNet+ model #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayers and nuclear instance segmentation/classification.
…ayers and nuclear instance segmentation/classification.
…ayers and nuclear instance segmentation/classification.
…ayers and nuclear instance segmentation/classification.
Contributor
|
Hi @adamshephard, just wanted to check what the status of this is? Is it ready to be merged but needs reviewing? I see there is a one merge conflict, but that should hopefully be easy to resolve. Are the unit tests passing locally for you? They do not appear to have run on this PR for some reason. |
Contributor
Author
|
Member
|
There are a few conflicts, also it's not running tests on travis. |
…hard/tiatoolbox into add-hovernet-plus-model
shaneahmed
reviewed
Nov 12, 2021
vqdang
suggested changes
Nov 18, 2021
Contributor
vqdang
left a comment
vqdang
left a comment
There was a problem hiding this comment.
Need to fix functions placement.
shaneahmed
reviewed
Nov 30, 2021
shaneahmed
reviewed
Nov 30, 2021
shaneahmed
reviewed
Nov 30, 2021
shaneahmed
reviewed
Nov 30, 2021
Member
shaneahmed
left a comment
shaneahmed
left a comment
There was a problem hiding this comment.
Thanks @adamshephard
Please can you address the comments?
vqdang
approved these changes
Nov 30, 2021
Contributor
vqdang
left a comment
vqdang
left a comment
There was a problem hiding this comment.
Minor comment need to clarify, looks ok otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model can be used for the simultaneous semantic segmentation of layers and nuclear instance segmentation/classification.