DEV: Update links for Kather dataset #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shaneahmed
commented
Oct 27, 2021
shaneahmed
commented
- Update links for katherdataset
- Use small sample for kather test. Full zip is only for local tests.
- Update links for katherdataset - Use small sample for kather test. Full zip is only for local tests.
- Fix bugs generated as a result relinking kather dataset
Codecov Report
@@ Coverage Diff @@
## develop #173 +/- ##
========================================
Coverage 99.79% 99.79%
========================================
Files 40 40
Lines 2959 2979 +20
Branches 492 499 +7
========================================
+ Hits 2953 2973 +20
Misses 1 1
Partials 5 5
Continue to review full report at Codecov.
|
- Ignore coverage for local test - Fix typo
- Add test for non-existing directory to improve coverage.
shaneahmed
commented
Nov 4, 2021
tests/models/test_dataset.py
Outdated
| "https://zenodo.org/record/53169/files/" | ||
| "Kather_texture_2016_image_tiles_5000.zip" | ||
| "https://tiatoolbox.dcs.warwick.ac.uk/datasets" | ||
| "/kather100k-validation-norm-subset-90.zip" |
Member
Author
There was a problem hiding this comment.
@John-P I think @simongraham is referring to this line.
shaneahmed
commented
Nov 4, 2021
| "06_MUCOSA", | ||
| "07_ADIPOSE", | ||
| "08_EMPTY", | ||
| "BACK", |
Member
Author
There was a problem hiding this comment.
@vqdang I think this is in line with kather100k set.
- Update links in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.