Skip to content

Conversation

@John-P
Copy link
Contributor

@John-P John-P commented Oct 22, 2021

Make spelling checks a blocking pre-commit issue again and sort pre-commit flake8 dependency lines to be alphabetical

@John-P John-P requested a review from shaneahmed October 22, 2021 10:17
@John-P John-P changed the title DEV: Remove Non-Blocking Pre-Commit Checks [skip travis] DEV: Remove Non-Blocking Pre-Commit Checks Oct 22, 2021
@John-P
Copy link
Contributor Author

John-P commented Oct 22, 2021

@shaneahmed Please review and merge if you are happy with this.

Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you add how to ignore code complexity in the description for this PR?
We can then merge it.

- Set max-cognitive-complexity to 11
- Fix opencv resize error with v4.5.4
- Revert opencv bug fix
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #168 (32bbd56) into develop (e718398) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #168      +/-   ##
===========================================
- Coverage    99.92%   99.82%   -0.11%     
===========================================
  Files           40       40              
  Lines         2751     3382     +631     
  Branches       458      605     +147     
===========================================
+ Hits          2749     3376     +627     
  Misses           1        1              
- Partials         1        5       +4     
Impacted Files Coverage Δ
tiatoolbox/models/architecture/vanilla.py 100.00% <100.00%> (ø)
tiatoolbox/models/controller/semantic_segmentor.py 100.00% <100.00%> (ø)
tiatoolbox/utils/transforms.py 100.00% <100.00%> (ø)
tiatoolbox/wsicore/wsireader.py 99.52% <0.00%> (-0.48%) ⬇️
tiatoolbox/wsicore/wsimeta.py 100.00% <0.00%> (ø)
tiatoolbox/models/dataset/classification.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e562e5c...32bbd56. Read the comment docs.

@shaneahmed shaneahmed merged commit 748ed2a into develop Oct 25, 2021
@shaneahmed shaneahmed deleted the dev-travis-checks branch October 25, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants