-
Notifications
You must be signed in to change notification settings - Fork 102
NEW: Add SlideGraph Construction Method In Tools #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #155 +/- ##
=========================================
Coverage 99.78% 99.79%
=========================================
Files 46 47 +1
Lines 3780 3909 +129
Branches 621 646 +25
=========================================
+ Hits 3772 3901 +129
Misses 2 2
Partials 6 6
Continue to review full report at Codecov.
|
tiatoolbox/tools/graph.py
Outdated
| # All rights reserved. | ||
| # ***** END GPL LICENSE BLOCK ***** | ||
|
|
||
| """Functions to help with constructing graphs.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it is just torch based graphs then please mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to expand this later to generic graph construction that we often use, not restricting to just torch. Ideally we would need to package the Graph as some data form and support .to_torch_geoemtry .to_networkx
shaneahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vqdang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need clarification for functionalities. IMO there are some questionable points about the implementation but that can be dealt with later.
I do not think it is necessary. But you can go ahead to make the code neat. |
Use `plt.triplot` with traingles for faster graph plotting.
- Add new line at the end of docstring
shaneahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @John-P
shaneahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @John-P
Add classes and functions under
tiatoolbox.tools.graphto enable construction of graphs in a format which can be used with PyG (PyTorch Geometric).