Skip to content

Conversation

@faretek1
Copy link
Collaborator

@faretek1 faretek1 commented Jun 7, 2025

  • change site.classroom.Classroom into a dataclass
  • fixes a minor bug when connecting to mystuff_classes (due to changes when decoding session id)
  • uses commons.headers instead of importing headers (just reduce number of global vars)
  • fixes a bug where all classroom activity raw strings return the default case of "{user} performed an action."

@faretek1
Copy link
Collaborator Author

faretek1 commented Jun 7, 2025

It is practically impossible to currently completely exhaust all possible bugs. But if we are to implement automated testing, and people report bugs, any things I missed would be solvable. In addition, most people do not use the classroom class so I will be able to test this myself

I do not see any obvious reason why this pr would break things right now, as the basic functionality works on my device

@faretek1 faretek1 merged commit bbe294f into TimMcCool:main Jun 7, 2025
@faretek1 faretek1 deleted the classroom-dataclass branch June 7, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant