Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correctly decode sb2 (#415)
(project data that is not sent as project JSON, but as a sb2 (zip) file)
Sometimes, regarding 2.0 projects, the regular JSON endpoint for the project actually returns an sb2 file. This pull request
project.jsonfrom the zip, if the previous error is caughtNote
It is interesting to note that both sa.editor and project_json_capabilities use this same method for getting project JSON data by id, but it is wasteful to not cache the asset data included within the zip file. Since both of these submodules use this method, there is also probably not going to be code duplication.
I tested this like so:
todo: