Skip to content

Fix numpy.sum overflow in aggregate tests #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

Fix numpy.sum overflow in aggregate tests #2245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tiledb/tests/test_aggregates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ def get_test_data(dtype, use_corner_cases, size=10):
assert max_result == max(expected)

# For sum and mean, handle corner cases differently
expected_sum = np.sum(expected)
expected_mean = np.sum(expected) / len(expected)
expected_sum = sum(int(x) for x in expected)
expected_mean = expected_sum / len(expected)

assert sum_result == expected_sum
assert mean_result == expected_mean
Expand Down Expand Up @@ -123,8 +123,11 @@ def get_test_data(dtype, use_corner_cases, size=10):
assert sub_count == len(expected_sub)
assert sub_min == min(expected_sub)
assert sub_max == max(expected_sub)
assert sub_sum == np.sum(expected_sub)
assert sub_mean == np.sum(expected_sub) / len(expected_sub)

expected_sub_sum = sum(int(x) for x in expected_sub)
expected_sub_mean = expected_sub_sum / len(expected_sub)
assert sub_sum == expected_sub_sum
assert sub_mean == expected_sub_mean

assert q.agg({"a": "sum"})[4:7] == sub_sum
assert q.agg({"a": "min"})[4:7] == sub_min
Expand Down
Loading