Fix: respect context params during vacuum when no config is provided #2236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kounelisagis
force-pushed
the
agis/fix-passing-empty-config-vacuum
branch
from
210387c to
bc89084
Compare
ihnorton
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to what was done in #2212, this PR addresses an issue that occurred when no Config was provided by the user during array vacuum. In such cases, the vacuum parameters set in the Context were ignored because an empty Config object was implicitly created in the Python layer and passed to the C++ API, which then took precedence over the Context.
This PR also adds the first test that uses
"commits"mode. The test is failing before this PR.Completes CORE-288