-
Notifications
You must be signed in to change notification settings - Fork 24
SMTP Auth #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msztolcman
wants to merge
12
commits into
ThiefMaster:master
Choose a base branch
from
msztolcman:smtp-auth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SMTP Auth #28
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
893f4ad
added custom SMTPChannel and it's usage in SMTP class
msztolcman 1b6948c
handling new options: smtp-auth, smtp-username, smtp-password
msztolcman a2cba14
removed crap from EHLO
msztolcman b95f1a9
fixed debug stream
msztolcman 0b1758b
do not allow for any command if unauthorized
msztolcman b06382a
parenthesis instead of backslash in condition
msztolcman 9752138
do not use smtp username and password from CLI options, just use HTPA…
msztolcman 3f687a9
more info about security issue about --smtp-auth option
msztolcman c892cd6
there are different implementations of SMTP auth password, sometimes …
msztolcman fcf5a21
updated smtp auth for new version of maildump
msztolcman f734a82
post review changes
msztolcman 2088102
better grammar
msztolcman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to override all this? A quick google search pointed me to this patch from this python issue where someone tried to get smtp auth support upstream, and they don't override EHLO. However, I don't know how good that implementation is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how in other way push info about AUTH PLAIN to capabilities.