-
-
Notifications
You must be signed in to change notification settings - Fork 62
Add ESM build output and improve package exports for better module compatibility #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix: for custom targets and update year in LICENSE to current
b706e90 to
b5db4c1
Compare
|
@TheSGJ do you have any update? |
|
Hey @TheSGJ do you have an estimated timeline for merging this? It doesn't seem a distructive change to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds ESM (ECMAScript Module) build output alongside the existing CommonJS format to improve module compatibility for modern JavaScript environments. The changes enable dual-format publishing to support both import and require syntax.
Key changes:
- Adds ESM format to the build configuration
- Updates package.json exports to support both ESM and CommonJS formats
- Adds explicit module entry point for ESM consumers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tsup.config.ts | Adds ESM format to build output alongside existing CJS |
| package.json | Updates exports map to support dual module formats and adds module field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hey, so sorry for the delayed reply. This code looks good for implementing ESM support. I will now merge these changes. |
Originally posted by @Daniel3711997 in #138 I will revert this PR as it seems to be causing issues with ESM export support. Will look into this again later |
Merge request about this issue #130