Skip to content

Remove erroneous input preprocessing #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Alrysc
Copy link

@Alrysc Alrysc commented Jul 30, 2025

Removes some code that was accidentally added when cleaning up the logging, which appeared to cause desyncs sometimes.

TheMaverickProgrammer and others added 30 commits January 4, 2022 21:01
…on() and set_move_direction(). fixed 1 letter-off Personal menu area name. un-auto'd my code
Allow component creation for more entity types and add is_counterable function
…ata. shaking fx is requeued if not in time freeze due to drag or applied earlier otherwise.
…ad' point in blind status used otherwise it is calculated from player height
… on chip art. Emotion window UI flicker speed adjusted. Fixed counters not appearing. Removed more auto's.
…t for swoosh::Timer which uses seconds. ESC key in battle must have app in focus to trigger. Tweaked some problems detecting and displaying combos and counter info text.
…n updates that serve to refresh the screen. Frame time objects replace swoosh timers.
…ut's in mob battle scene and network battle scene.
…s subtracted from the entity's health. updated sound font.
…her misc. Some of these need to be undone later.
…nloadScene handshake, aborts if version mismatch detected. Remove net logging from InputManager.
 help sync softlocks on scene start and shouldn't desync because inputs are not being sent yet. Bump version.
…rting and ending. CustomBarProgress is now reset in CardSelectBattleState::onStart instead of the CombatBattleState. Version bump.

The desync fixed was one where being decrossed during the turn and then not choosing a form on the following card select would cause the remote player to think you changed forms to the form at -1, which would animate and desync.

SetCustomBarProgress call moved in order to prevent progress from resetting during transitions between combat and transformation state during combat, ,such as through decross. Transformation state should not be added as a subcombat state, so this makes more sense.
@TheMaverickProgrammer TheMaverickProgrammer merged commit d8dce1a into TheMaverickProgrammer:master Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants