fix: update the location of moved or replaced containers #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements the UpdateLocation method for storage containers to properly update their location references when files are moved or replaced. This fixes an issue where containers retained stale location information after file system operations.
- Adds
UpdateLocationmethod to theIStorageContainerinterface and all implementing classes - Updates file move and replace operations to call
UpdateLocationwhen containers change location - Adds test coverage for multiple replace operations to verify the fix works correctly
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Testably.Abstractions.Testing/Storage/IStorageContainer.cs | Adds UpdateLocation method to the interface |
| Source/Testably.Abstractions.Testing/Storage/InMemoryContainer.cs | Implements UpdateLocation by updating the internal location field |
| Source/Testably.Abstractions.Testing/Storage/NullContainer.cs | Implements UpdateLocation as a no-op for the null container |
| Tests/Testably.Abstractions.Testing.Tests/TestHelpers/LockableContainer.cs | Implements UpdateLocation as a no-op for the test helper |
| Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs | Updates replace and move operations to call UpdateLocation |
| Tests/Testably.Abstractions.Tests/FileSystem/File/ReplaceTests.cs | Adds test for multiple replace operations |
| Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ReplaceTests.cs | Adds test for multiple replace operations |
|
|
This is addressed in release v4.3.7. |
This was referenced Sep 12, 2025
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 22, 2025
Closed
Closed
This was referenced Oct 7, 2025
This was referenced Oct 14, 2025
This was referenced Oct 24, 2025
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
UpdateLocationmethod for storage containers to properly update their location references when files are moved or replaced. This fixes an issue where containers retained stale location information after file system operations.Key changes:
UpdateLocationmethod to theIStorageContainerinterface and all implementing classesUpdateLocationwhen containers change location