fix: DirectoryMock.EnumerateDirectories does not throw exceptions until enumerated #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split InMemoryStorage.EnumerateLocations into validation and implementation methods. Validation and exceptions now occur immediately when method is called, while enumeration logic happens during iteration as expected. Co-authored-by: vbreuss <[email protected]>
Updated EnumerateDirectories statistics tests to create directories first, ensuring they test successful method calls rather than exception paths. The fix maintains proper statistics tracking while enabling immediate exception throwing for missing directories. Co-authored-by: vbreuss <[email protected]>
Copilot
AI
changed the title
[WIP] DirectoryMock.EnumerateDirectories does not throw exceptions until enumerated
fix: DirectoryMock.EnumerateDirectories does not throw exceptions until enumerated
Sep 11, 2025
Copilot finished work on behalf of
vbreuss
September 11, 2025 04:23
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where DirectoryMock.EnumerateDirectories (and related enumeration methods) did not match the behavior of the real Directory.EnumerateDirectories implementation. The real file system throws IO exceptions immediately when the enumeration method is called on a non-existent directory, but the mock implementation only threw exceptions during iteration.
- Split
InMemoryStorage.EnumerateLocationsinto validation and implementation phases to throw exceptions immediately - Added new test cases to verify immediate exception throwing behavior for all enumeration methods
- Updated statistics tests to create directories before enumeration to avoid exception scenarios
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs | Refactored EnumerateLocations to separate immediate validation from lazy enumeration implementation |
| Tests/Testably.Abstractions.Tests/FileSystem/Directory/EnumerateDirectoriesTests.cs | Added test verifying immediate exception throwing on missing directory |
| Tests/Testably.Abstractions.Tests/FileSystem/Directory/EnumerateFilesTests.cs | Added test verifying immediate exception throwing on missing directory |
| Tests/Testably.Abstractions.Tests/FileSystem/Directory/EnumerateFileSystemInfosTests.cs | Added test verifying immediate exception throwing on missing directory |
| Tests/Testably.Abstractions.Testing.Tests/Statistics/FileSystem/DirectoryStatisticsTests.cs | Updated enumeration statistics tests to create directories first |
| Tests/Testably.Abstractions.Testing.Tests/Statistics/FileSystem/DirectoryInfoStatisticsTests.cs | Updated enumeration statistics tests to create directories first |
Test Results 37 files ± 0 37 suites ±0 21m 32s ⏱️ +17s For more details on these failures, see this check. Results for commit eb0bb1a. ± Comparison against base commit 46eb8ff. This pull request removes 36227 and adds 36327 tests. Note that renamed tests count towards both.This pull request removes 1784 skipped tests and adds 1784 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
vbreuss
approved these changes
Sep 11, 2025
|
|
This is addressed in release v4.3.6. |
This was referenced Sep 11, 2025
Closed
Closed
This was referenced Sep 15, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 22, 2025
Closed
Closed
This was referenced Oct 7, 2025
This was referenced Oct 14, 2025
This was referenced Oct 24, 2025
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DirectoryMock.EnumerateDirectoriesmethod was not matching the behavior of the realDirectory.EnumerateDirectoriesimplementation. The real implementation throws IO exceptions (likeDirectoryNotFoundException) immediately when the method is called, but the mock implementation only threw these exceptions when the returnedIEnumerablewas actually enumerated.Problem
This discrepancy could cause tests to pass when they should fail, or miss edge cases in exception handling logic.
Solution
Split
InMemoryStorage.EnumerateLocationsinto two methods:EnumerateLocations()- Performs immediate validation (directory exists, valid search pattern) and throws exceptions synchronouslyEnumerateLocationsImpl()- Contains the actual yield-based enumeration logic that executes during iterationThis ensures validation and exception throwing happens at method call time, while preserving the lazy enumeration behavior for the actual iteration over results.
Changes
The fix applies to all enumeration methods:
EnumerateDirectories()EnumerateFiles()EnumerateFileSystemEntries()