Fixed most of the Portability Report issues #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Trace still not working.
| using System; | ||
| using System.Runtime.Serialization; | ||
|
|
||
| [Serializable] |
There was a problem hiding this comment.
You could polyfill this if you wanted. Removing for everyone means you can no longer take exception across appdomains
There was a problem hiding this comment.
By polyfill, do you mean #if statements?
There was a problem hiding this comment.
Create an attribute in your code in the right namespace. Does nothing but don't need ifs.
There was a problem hiding this comment.
OK, I see what you mean. But then I would still need an #if for the serializable constructor?
…iling for reports. Also removed the resx as I was having issues loading it. Possibly related to aspnet/Tooling#532
First pass at making coreclr compatible
Fixed stack overflow issue in the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took dependency on Json.Net which is hopefully only temporary.
Outstanding issues are AppDomain unload and StackTrace.