Skip to content

Conversation

@Vicwin13
Copy link
Collaborator

@Vicwin13 Vicwin13 commented Aug 7, 2025

📝 Description

Triggering of error messages to fields that are not selected or filled.

🔂 Changes Made

changes made in the internal script file

⚙️ Related Issue

🍏 Type of Change

  • Bug fix

🧰 New Environment Variables or Requirements

none

✅ Checklist

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have commented my code where necessary.
  • I have tested my code locally and verified the website is working as expected.

@Vicwin13 Vicwin13 requested a review from daaimah123 August 7, 2025 15:47
Copy link
Collaborator

@daaimah123 daaimah123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vicwin13 Please update this PR's based branch to be mvp and update your feature branch with mvp. At present this PR is adding in additional work that is actually present in the mvp branch, making much of this PR out of scope for the changes requested. Thank you.

develop to mvp

Please also be sure to push up your changes, as is I don't see any new commit history from you.

@daaimah123 daaimah123 moved this to Testing or Review in Application Process Automation Aug 7, 2025
@Vicwin13 Vicwin13 closed this Aug 8, 2025
@github-project-automation github-project-automation bot moved this from Testing or Review to Implemented or Addressed ✅ in Application Process Automation Aug 8, 2025
@Vicwin13 Vicwin13 reopened this Aug 8, 2025
@Vicwin13
Copy link
Collaborator Author

Vicwin13 commented Aug 8, 2025

error

this is what I get @daaimah123

@daaimah123
Copy link
Collaborator

@Vicwin13 that error is saying that this PR does not contain any new work that is different from the mvp branch. In summary, we cannot have a PR that merges a cloned branch with no changes into the same branch, because they are the same.

Please push up your changes that were implemented onto your feature branch and then you will be able to change the base branch.

@Vicwin13 Vicwin13 changed the base branch from develop to refactor-base-template-js August 12, 2025 12:02
@Vicwin13 Vicwin13 changed the base branch from refactor-base-template-js to develop August 12, 2025 13:53
@daaimah123 daaimah123 changed the base branch from develop to mvp August 26, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Implemented or Addressed ✅

Development

Successfully merging this pull request may close these issues.

Application Form /app-questionnaire.html Form Validation Errors Not Triggering Correctly

3 participants