Skip to content

Conversation

@Phil-NHS
Copy link

@Phil-NHS Phil-NHS commented Nov 3, 2025

‼️ This change requires View Component Package NHSUKViewComponents.Web changing to NHSE-TEL-View-Components
Both need to be in the test branch together‼️

Without this change you will see backlinks with two overlapping chevron for example.
This is because NHSUKViewComponents.Web also relies on nhsuk-frontend but is currently expecting an older version.

Task to update View Components package to NHSE-TEL-View-Components TD-6421
image

JIRA link

TD-6227

Description

Remove TEL-Frontend and replacing with NHSE-Frontend. Then upgrading to NHSE-Frontend 10.x
I have look through a few screen and compared with the NHSE-Frontend showcase, and DLS Production.
The secondary button has changed for example.

The page template has changed. And svgs have been dropped and replaced with pseudos with css shapes.

Because of this using nhsuk-back no longer works with anything but the cancel buttons, it had been used for other purposes like cancel. Instead the change decided on was to use nhsuk-link and remove the svg. So cancel should no longer have an X or a chevron for example.

The View Components package still expects the older version of NHSE-Frontend so will show both the cross and chevron until it has been updated.

There is an extensive list of changes here https://service-manual.nhs.uk/design-system/guides/updating-to-v10

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
    Web tests all work the other didnt all work locally for me before the changes, I would like to to be shown how to do this
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@Phil-NHS Phil-NHS requested a review from rshrirohit November 3, 2025 11:23
@Phil-NHS Phil-NHS self-assigned this Nov 3, 2025
@Phil-NHS Phil-NHS marked this pull request as ready for review November 4, 2025 15:47
@Phil-NHS Phil-NHS marked this pull request as draft November 4, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants