feat(store/bbolt): implement actor pattern #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xe Iaso <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Xe Iaso <[email protected]>
check-spelling run (pull_request) for Xe/actorify Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1103
Previously there was a lock convoy (thundering herd around mutices) when using the bbolt store while your service is being hammered by requests. This changes the bbolt store to use the Actor pattern instead of having a cage match over the database lock. Notably, this does serialize getting, setting, and deleting keys, but that's probably fine for now. If this becomes an issue, we can change how actorify works to make it spawn multiple actor threads.
At this point the main CPU use in high request pressure scenarios is the garbage collector. This does have an impact on the response time of services proxied by Anubis, however this is a bit of a non-issue because in such a scenario Anubis is absorbing the impact instead of the target service. This will be fixed by better using buffer pools.
Checklist:
[Unreleased]section of docs/docs/CHANGELOG.mdnpm run test:integration(unsupported on Windows, please use WSL)