feat: allow to set cookie sameSite mode and fallback to Lax mode if cookie is not secure #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaab
force-pushed
the
new-same-site-mode
branch
from
0defa82 to
92abc5e
Compare
vaab
changed the title
vaab
force-pushed
the
new-same-site-mode
branch
from
92abc5e to
aad3ce3
Compare
Xe
approved these changes
Sep 10, 2025
vaab
force-pushed
the
new-same-site-mode
branch
from
aad3ce3 to
2523b93
Compare
Contributor
|
@vaab please rebase against main. I'd do it for you but you disabled my ability to do that. |
Also, will allow to set cookie `SameSite` mode on command line or environment. Note that `None` mode will be forced to ``Lax`` if cookie is set to not be secure. Signed-off-by: Valentin Lab <[email protected]>
auto-merge was automatically disabled
September 13, 2025 09:03
Head branch was pushed to by a user without write access
vaab
force-pushed
the
new-same-site-mode
branch
from
2523b93 to
4ccbad0
Compare
Contributor
Author
|
@Xe No problem, I rebased (only the changelog had trivial conflicts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anubis can't be used on pure HTTP mode without this and despite having introduced the COOKIE_SECURE option.
Indeed, browser will refuse cookie in None mode if the cookie is unsecure.
Checklist:
[Unreleased]section of docs/docs/CHANGELOG.mdnpm run test:integration(unsupported on Windows, please use WSL)