Skip to content

[SoundCloud] Miscellaneous refactors #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

[SoundCloud] Miscellaneous refactors #1323

wants to merge 13 commits into from

Conversation

absurdlylongusername
Copy link
Member

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Some minor refactorings

  • Add toString to DateWrapper for better debugging
  • make SoundcloudStreamExtractor.getTimeStamp return 0 if not timestamp found in the url
  • Use Pattern instead of String in regex for SoundcloudStreamLinkHandlerFactory
  • Refactor Parser.java
  • Refactor AudioStream constructor to take builder instead of many parameters
  • Other minor changes

@absurdlylongusername
Fix typo
9bbcea9
@absurdlylongusername
Remove redundant override
cefb29b
@absurdlylongusername
[SoundCloud] SoundCloudStreamExtractor.getTimeStamp return 0 if no ti…
a208830 
…mestamp in url
@absurdlylongusername
Fix typo
9bfcf5c
@absurdlylongusername
[Localization] Add toString to DateWrapper for better debugging
6e9e09d
@absurdlylongusername
[SoundCloud] Use Pattern instead of string for regex in SoundcloudStr…
4c183af 
…eamLinkHandlerFactory

Use non-capturing groups in regex
Refactor Parser.java
Add more utility methods (will be used in later commits)
@absurdlylongusername
Refactor Description constructor
0537f04
@absurdlylongusername
Remove redundant initialization
3252a72
@absurdlylongusername
Remove matchNamedGroup methods from Parser.java as not available on A…
28baa47 
…ndroid API < 26
@absurdlylongusername
Refactor AudioStream constructor to use builder instead of explicit p…
575376d 
…arameters. Refactor documentation also
@absurdlylongusername
List.of IDE suggestions refactoring
eac18b2
@absurdlylongusername
CamelCase typo
6b6ae8b
This was referenced Jul 8, 2025
Open
Closed
@TobiGr TobiGr added soundcloud service, https://soundcloud.com/ codequality Improvements to the codebase to improve the code quality labels Jul 8, 2025
@absurdlylongusername absurdlylongusername mentioned this pull request Jul 8, 2025
Open
3 tasks
@ShareASmile ShareASmile changed the title Miscellaneous refactors [SoundCloud] Miscellaneous refactors Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality soundcloud service, https://soundcloud.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@absurdlylongusername @TobiGr