Enable type-checking for visualization.py
#347
Conversation
This commit adds type annotations to `visualization.py`, along with its corresponding tests, enabling full type-checking with mypy while preserving existing functionality. **Related issue:** This PR continues the work started in TeamGraphix#302, TeamGraphix#308, and TeamGraphix#312.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 79.52% 85.86% +6.34%
==========================================
Files 41 42 +1
Lines 5793 5704 -89
==========================================
+ Hits 4607 4898 +291
+ Misses 1186 806 -380 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Eventually we should update the docstrings for consistency too.
There was a problem hiding this comment.
- Do we want to change all the figsize variables to _Point = tuple[float, float] type?
- Line 768 do we want to give a more descriptive ValueError?
- Additional bug noticed in GraphVisualizer init . If no measurement planes input, generated measurement planes include measurements on output nodes. I will make an issue for this.
There was a problem hiding this comment.
I think that even if figsize could formally be of type _Point, it makes sense to distinguish them since a size is semantically different than a point. The two other issues should have been fixed by the refactoring. Thanks!
|
I just refactored the visualization module: the behavior should be unchanged, and the code logic is the same, but I reduced code duplication and improved test coverage. |
2 participants
This commit adds type annotations to
visualization.py, along with its corresponding tests, enabling full type-checking with mypy while preserving existing functionality.Related issue:
This PR continues the work started in #302, #308, and #312.