Skip to content

Conversation

Tyrannicodin
Copy link
Contributor

@Tyrannicodin Tyrannicodin commented Sep 11, 2024

Adds autocomplete to tags in the preview panel, for all tag fields.
You can now add tags through several methods:

  1. Beginning to type a tag's name and
    a. Clicking enter to get the first tag that matches the text
    b. Using the arrow keys to select a tag from the autocomplete popup
    c. Clicking on a tag from the autocomplete popup
  2. Clicking the plus button and using the previous tag modal.

Requires #481

@yedpodtrzitko
Copy link
Contributor

I'll read through the code, but same thing as with #481 - please add some tests to verify the behaviour automatically and to prevent regressions in future. There are some existing tests for widgets in tests/qt, so you can use these as an inspiration. Thank you.

@Tyrannicodin
Copy link
Contributor Author

Yep that's fine, I made this before I looked at that pr so can add some tests to both of them.

@yedpodtrzitko
Copy link
Contributor

@CyanVoxel can you please enable the workflow to run on this PR? Thanks.

@CyanVoxel CyanVoxel added Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience TagStudio: Tags Relating to the TagStudio tag system TagStudio: Search The TagStudio search engine labels Sep 11, 2024
@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Sep 11, 2024
@CyanVoxel CyanVoxel added the Priority: Medium An issue that shouldn't be be saved for last label Sep 11, 2024
Copy link
Contributor

@yedpodtrzitko yedpodtrzitko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@yedpodtrzitko
Copy link
Contributor

yedpodtrzitko commented Sep 12, 2024

here's a bug:

Steps to reproduce:

  • only Archived and Favorite tags exist
  • type meow into the field to add new tag & press Enter

Expected behaviour:

  • since no matching tag exists, no tag should be added

Current behaviour:

  • tag Archived is added

Copy link
Contributor

@yedpodtrzitko yedpodtrzitko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests for the widget, thanks.

@CyanVoxel CyanVoxel added the Status: Changes Requested Changes are quested to this label Sep 13, 2024
@Tyrannicodin
Copy link
Contributor Author

Added tests and fixed the bugs 👍

Copy link
Contributor

@yedpodtrzitko yedpodtrzitko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, beside the Enter behaviour on no-match. good job.

@Tyrannicodin
Copy link
Contributor Author

Changes made

@yedpodtrzitko
Copy link
Contributor

please fix the pipeline

@yedpodtrzitko
Copy link
Contributor

it's quite misbehaving

Screen.Recording.2024-09-22.at.8.21.15.mov

@Tyrannicodin
Copy link
Contributor Author

What. I've never seen it do that.
I'll look into it in the morning

@CyanVoxel CyanVoxel removed this from the Alpha v9.5 (Post-SQL) milestone Jan 4, 2025
@CyanVoxel
Copy link
Member

Closed in favor of the new tagging workflow introduced in #655 which provides the same benefits

@CyanVoxel CyanVoxel closed this Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last Status: Changes Requested Changes are quested to this TagStudio: Search The TagStudio search engine TagStudio: Tags Relating to the TagStudio tag system Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants