refactor(spnego): only add principal to keytab if it does not exist #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteBaum
force-pushed
the
fix/spnego-new-principal
branch
from
d9649b1 to
4fd3c81
Compare
SteBaum
changed the title
SteBaum
force-pushed
the
fix/spnego-new-principal
branch
2 times, most recently
from
30bef58 to
cbea2d4
Compare
SteBaum
force-pushed
the
fix/spnego-new-principal
branch
from
cbea2d4 to
ccfc0d3
Compare
SteBaum
force-pushed
the
fix/spnego-new-principal
branch
from
ccfc0d3 to
a434ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes #995
Additional comments
Adding a new principal for a new host in the
spnego.service.keytabdid not work.The tasks increate_headless_principal_keytab.ymlonly add new principal to the keytab if it is empty due to a condition. This condition has been removed, however for the already existing principals in the keytab not be added again, the plugin code had to be modified.Agreements