-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add design tokens and Container Section Card to Storybook #3744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
You can access the deployment of this PR at https://renku-ci-ui-3744.dev.renku.ch |
41a846c to
93aeed5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going through this PR and I have two main comments:
- Design tokens: I like the level of detail! That should cover most of the needs of the design team. However, using static strings for the style attributes we wish to capture isn't the best approach. We would need to manually update those strings if we update anything on Bootstrap. We can check the rendered elements instead using
getComputedStyle - Molecules: Great to include more examples and longer descriptions wherever necessary (Cards are a good example) but sections like "Layout & Spacing" or "Typography" seem unnecessary (E.G. we don't need to say that card's background are white, nor that the class
.bg-whiteis applied -- which isn't the case) and hard to maintain in the long run (not extracted automatically).
In the reference pitch there was something about exporting to Figma but I don't see from here how it is done.
| black: { value: "#000000", notes: "" }, | ||
| }, | ||
| text: { | ||
| "text-primary": { value: "#006e58" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can get the values using a function like getComputedStyle instead of hardcoding
This PR introduces foundational updates to our Storybook:
✅ What's included
Design Tokens: New stories for the following tokens used across our UI:
Container Section Card: First documented component added under the new structure, following improved documentation practices for component stories in Storybook.
📚 Why this matters
We’ve started reorganizing our Storybook to align with the Atomic Design methodology, which the design team also follows. This structure will help improve consistency, reusability, and collaboration between design and development teams.
Our new Storybook structure looks like this:
📌 Next steps / To-dos for upcoming PRs
Data connectorcard spacing (me-2instead ofgap-2).d-flex justify-content-betweeninstead ofms-autoReferences
/deploy renku=release-2.5.0
! RESTORE THE PREVIOUS POINTER to
andrea/simplify-dc-form