Skip to content

Conversation

@andre-code
Copy link
Contributor

@andre-code andre-code commented Jun 26, 2025

This PR introduces foundational updates to our Storybook:

✅ What's included

  • Design Tokens: New stories for the following tokens used across our UI:

    • Colors
    • Spacing
    • Fonts
    • Borders & Shadows
    • Opacity
  • Container Section Card: First documented component added under the new structure, following improved documentation practices for component stories in Storybook.

📚 Why this matters

We’ve started reorganizing our Storybook to align with the Atomic Design methodology, which the design team also follows. This structure will help improve consistency, reusability, and collaboration between design and development teams.

Our new Storybook structure looks like this:

📁 Design Tokens
  ├── Colors ✅
  ├── Spacing ✅
  ├── Fonts ✅
  ├── Borders & Shadows ✅
  └── Opacity ✅

📁 Atoms
  ├── Button
  ├── Input
  ├── Badge
  └── Lists
      ...

📁 Molecules
  ├── Card
  │    └── ContainerSectionCard ✅
  ├── Modal
  └── ...

Ref: [Atomic Design by Brad Frost](https://bradfrost.com/blog/post/atomic-web-design/)

📌 Next steps / To-dos for upcoming PRs

  • Create a ContainerSectionCard component
  • Fix layout inconsistencies in related cards and sections:
    • Update Data connector card spacing (me-2 instead of gap-2)
    • Update "My Projects" and "My Group Projects" spacing to use .d-flex justify-content-between instead of ms-auto
    • Move description into the body for “Session Secret Slots” card and apply proper text styles
    • Add a Figma link to Storybook for design reference

References

/deploy renku=release-2.5.0
! RESTORE THE PREVIOUS POINTER to andrea/simplify-dc-form

@andre-code andre-code temporarily deployed to renku-ci-ui-3744 June 26, 2025 09:27 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3744.dev.renku.ch

@andre-code andre-code force-pushed the andrea/add-design-tokens-storybook branch from 41a846c to 93aeed5 Compare July 3, 2025 07:17
@andre-code andre-code temporarily deployed to renku-ci-ui-3744 July 3, 2025 07:17 — with GitHub Actions Inactive
@andre-code andre-code marked this pull request as ready for review July 3, 2025 07:22
@andre-code andre-code requested a review from a team as a code owner July 3, 2025 07:22
@andre-code andre-code temporarily deployed to renku-ci-ui-3744 July 3, 2025 08:19 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-3744 July 4, 2025 07:05 — with GitHub Actions Inactive
@andre-code andre-code changed the title feat: add design tokens in Storybook feat: add design tokens and Section Content Card in Storybook Jul 4, 2025
@andre-code andre-code temporarily deployed to renku-ci-ui-3744 July 4, 2025 08:29 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-3744 July 4, 2025 08:47 — with GitHub Actions Inactive
@andre-code andre-code changed the title feat: add design tokens and Section Content Card in Storybook feat: add design tokens and Container Section Card in Storybook Jul 4, 2025
@andre-code andre-code changed the title feat: add design tokens and Container Section Card in Storybook feat: add design tokens and Container Section Card to Storybook Jul 4, 2025
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going through this PR and I have two main comments:

  • Design tokens: I like the level of detail! That should cover most of the needs of the design team. However, using static strings for the style attributes we wish to capture isn't the best approach. We would need to manually update those strings if we update anything on Bootstrap. We can check the rendered elements instead using getComputedStyle
  • Molecules: Great to include more examples and longer descriptions wherever necessary (Cards are a good example) but sections like "Layout & Spacing" or "Typography" seem unnecessary (E.G. we don't need to say that card's background are white, nor that the class .bg-white is applied -- which isn't the case) and hard to maintain in the long run (not extracted automatically).

In the reference pitch there was something about exporting to Figma but I don't see from here how it is done.

black: { value: "#000000", notes: "" },
},
text: {
"text-primary": { value: "#006e58" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get the values using a function like getComputedStyle instead of hardcoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants