Skip to content

feat!: add a convenient way to add an openBIS cloud storage #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 22, 2025
Merged

feat!: add a convenient way to add an openBIS cloud storage #3238

merged 12 commits into from
Oct 22, 2025

Conversation

@olloz26
Copy link
Collaborator

@olloz26 olloz26 commented Jul 11, 2024 •
edited by lorenzo-cavazzi
Loading

/deploy renku-data-services=pitch/connect-renkulab-and-openbis-datasets-resolve-conflicts-2

@olloz26 olloz26 requested a review from a team as a code owner July 11, 2024 13:39
lorenzo-cavazzi
lorenzo-cavazzi reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Can't wait to try it with a working backend :)

I added a couple of comments inline.

client/src/features/project/components/cloudStorage/projectCloudStorage.types.ts Outdated
hide?: boolean;
prefix: string; // ? weird naming; it's the machine readable name
position?: number;
convenientMode?: boolean; // ? Disables the advanced mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should include this; even if it makes little sense for users to mess with the config directly, they might still want to copy/paste the configuration string to pass it to other users to simplify setting up a working solution. I think we should remove it.

@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Aug 13, 2024
@lorenzo-cavazzi
Copy link
Member

@olloz26 Sorry for the delay; I'll review this soon.
Do we have a backend for this? Could you point me to the PRs on data-service and renku-notebooks?

P.S. It would be great if you could resolve the conflicts

@lorenzo-cavazzi
Copy link
Member

@olloz26 any update on this?

@olloz26 olloz26 force-pushed the olloz26/connect-renkulab-and-openbis-datasets branch from a6d93d4 to 5116b0e Compare November 20, 2024 13:56
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3238.dev.renku.ch

@lorenzo-cavazzi
Copy link
Member

Discussed changes:

  • Drop the convenientMode and check whether there are advanced options to show/hide the switch
  • Add a "required" label next to the required field and improve the popup message on the Test Connection button whenever required fields are missing
  • Rename readOnly to forceReadOnly and check that also the code for editing existing data connectors considers this setting

@olloz26 olloz26 force-pushed the olloz26/connect-renkulab-and-openbis-datasets branch from 5116b0e to 101004e Compare October 2, 2025 15:39
lorenzo-cavazzi
lorenzo-cavazzi requested changes Oct 10, 2025
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! I added some inline comments to either optimize the code or remove unnecessary elements.

lorenzo-cavazzi
lorenzo-cavazzi requested changes Oct 14, 2025
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Just a final change on rendering React functions as React components instead of pure JavaScript functions (MyComponent() vs <MyComponent />) before merging 👍

@lorenzo-cavazzi lorenzo-cavazzi changed the base branch from main to olloz26/openbis-data-connectors October 16, 2025 11:57
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI side works well. Great to see this feature getting ready for the release 🙌

As discussed, let's merge into a feature branch (I've already changed the base) and keep it there until the backend is ready as well.

P.S. when you merge, please squash all the commits into a single commit -- the text looks good already in the title 👍

@lorenzo-cavazzi lorenzo-cavazzi merged commit 2daa452 into olloz26/openbis-data-connectors Oct 22, 2025
26 of 33 checks passed
@lorenzo-cavazzi lorenzo-cavazzi deleted the olloz26/connect-renkulab-and-openbis-datasets branch October 22, 2025 17:40
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

@lorenzo-cavazzi lorenzo-cavazzi mentioned this pull request Oct 22, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees

@lorenzo-cavazzi lorenzo-cavazzi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olloz26 @lorenzo-cavazzi @RenkuBot