-
Notifications
You must be signed in to change notification settings - Fork 2
fix: update API spec for patching session environments #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can access the deployment of this PR at https://renku-ci-ds-1073.dev.renku.ch |
Pull Request Test Coverage Report for Build 18943682560Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| type: array | ||
| items: | ||
| $ref: "#/components/schemas/Build" | ||
| StripPathPrefix: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these "not nullable" ones still used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for the responses and for the POST payloads.
|
Tearing down the temporary RenkuLab deployment for this PR. |
Closes #913, closes #985.
Update the API spec to allow
nullto be passed to resetargsandcommandin session environments.UI update: SwissDataScienceCenter/renku-ui#3888.
/deploy renku-ui=leafty/fix-session-env-api