Skip to content

Conversation

@leafty
Copy link
Member

@leafty leafty commented Oct 23, 2025

Closes #913, closes #985.

Update the API spec to allow null to be passed to reset args and command in session environments.

UI update: SwissDataScienceCenter/renku-ui#3888.

/deploy renku-ui=leafty/fix-session-env-api

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-1073.dev.renku.ch

@coveralls
Copy link

coveralls commented Oct 23, 2025

Pull Request Test Coverage Report for Build 18943682560

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 3 files are covered.
  • 14 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.04%) to 86.796%

Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/error_handler.py 1 87.5%
components/renku_data_services/crc/core.py 1 78.49%
components/renku_data_services/session/models.py 1 95.33%
components/renku_data_services/storage/blueprints.py 2 91.06%
components/renku_data_services/k8s/db.py 4 90.98%
components/renku_data_services/k8s/watcher/core.py 5 80.13%
Totals Coverage Status
Change from base Build 18941004583: -0.04%
Covered Lines: 22724
Relevant Lines: 26181

💛 - Coveralls

type: array
items:
$ref: "#/components/schemas/Build"
StripPathPrefix:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these "not nullable" ones still used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for the responses and for the POST payloads.

@leafty leafty enabled auto-merge (squash) October 30, 2025 12:23
@leafty leafty merged commit 116cfd7 into main Oct 30, 2025
31 checks passed
@leafty leafty deleted the leafty/fix-session-env-api branch October 30, 2025 14:36
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deployment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect API spec for global environments Removing the args and command on a session launcher does not work

5 participants