fix(transform): preserve export keywords on nested namespaces #360
+4
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #359
Removes two problematic code sections from PR #352:
Lines 26-28: Unnecessary
duplicateExports()call that caused superfluous export name duplication in namespace bodiesLines 596-605: Incorrect removal of export keywords from nested namespaces, which changed their accessibility from public to private
Problem
The previous implementation was removing
exportkeywords from nested namespaces, which:Changes
duplicateExports()invocation inpreProcessNamespaceBody()elseblock infixModifiers()that strippedexportfrom nested namespacesexportkeywords on nested namespaces