Skip to content

[Bugfix:Autograding] sql_runner w/ failed queries #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Conversation

emaicus
Copy link
Contributor

@emaicus emaicus commented Mar 16, 2021

The sql_runner failed to commit or rollback a transaction after it finished. As a result, if one query failed, all subsequent queries did, as well.

@emaicus emaicus changed the title [Bugfix:Tutorial18] Make sql_runner robust to failed queries [Bugfix:Autograding] Make sql_runner robust to failed queries Mar 16, 2021
@bmcutler bmcutler changed the title [Bugfix:Autograding] Make sql_runner robust to failed queries [Bugfix:Autograding] sql_runner w/ failed queries Mar 17, 2021
@bmcutler bmcutler merged commit b0e9743 into main Mar 17, 2021
@bmcutler bmcutler deleted the better_sql_runner branch March 17, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants