[Feature:Developer] Default Dates for sample data #11701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11701 +/- ##
=========================================
Coverage 21.04% 21.04%
Complexity 9079 9079
=========================================
Files 258 258
Lines 34860 34860
Branches 461 461
=========================================
Hits 7336 7336
Misses 27067 27067
Partials 457 457
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
I wanted to comment that this PR introduce the possibility of a develop forgetting about a date and failing the assertions. |
bmcutler
approved these changes
Jun 9, 2025
github-project-automation
bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
bmcutler
pushed a commit
to Submitty/Tutorial
that referenced
this pull request
Jul 16, 2025
Removes the dates for course config Related to Submitty/Submitty#11701 This ensures that the course never expires. Verified with `recreate_sample_courses tutorial`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The sample data has multiple dates, most of which are required. This could greatly increase the number of lines that any couese.yml has. IN addition, some of the fields in courses.yml were incorrect.
What is the new behavior?
Changes some of the fields in courses.yml to be correct. Sets the default date for every gradeable to be in the "OPENED" state with no possible overdue submissions.
Other information?