-
-
Notifications
You must be signed in to change notification settings - Fork 117
configurable utilityImage + clusterDomain and increase default db timeouts to avoid replicaset timeout #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure why the key is missing for the checks |
update fix default registry fix whitespace
76a0873 to
1332ae8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would break my setup, as, in my values:
- I include my private image registry in the name of all the images.
- I include
dnsConfig.searcheswith the cluster namespace so that searches for the short name always resolve.
9915e27 to
79711af
Compare
| #pullSecret: "your-pull-secret" | ||
|
|
||
|
|
||
| clusterDomain: cluster.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs some kind of doc string.
The clusterDomain is defined here: https://kubernetes.io/docs/reference/config-api/kubelet-config.v1beta1/#kubelet-config-k8s-io-v1beta1-KubeletConfiguration
And the DNS server has to be configured with it as well:
https://stackoverflow.com/a/52941407/1134951
Looks like kube-dns is the thing that defaults to cluster.local (overridable with the --domain param): https://github.com/kubernetes/dns/blob/master/cmd/kube-dns/app/options/options.go#L59
I use coredns where there is not a default domain, and I did not use the cluster.local domain shown in the docs: https://coredns.io/plugins/kubernetes/
How is your cluster's dns configured?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use coredns.
My configmap:
.:53 {
errors
health
kubernetes cluster.local in-addr.arpa ip6.arpa {
pods insecure
fallthrough in-addr.arpa ip6.arpa
}
prometheus :9153
forward . /etc/resolv.conf
cache 30
loop
reload
loadbalance
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my /etc/resolv.conf on the st2-api pod
search default.svc.cluster.local svc.cluster.local cluster.local [redacted]
nameserver 10.100.0.10
nameserver [redacted]
options ndots:5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the node my kubelet-config.json does have a line for:
{
...
clusterDomain": "cluster.local",
...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment here as well.
9d55607 to
d968971
Compare
1fc078e to
7ec5fb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment for the DB settings
remove hardcoded settings for retry to allow k8 to handle restarting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| # fixes no replicaset found bug; | ||
| [database] | ||
| # Connection and server selection timeout (in ms). | ||
| connection_timeout = 5000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. With 3s being default in st2, bumping it to 5s for K8s sounds like an improvement for distributed environment.
allow alternate proxy registry to be used with helm chart.
fix replica set timeout error
fix dns resolution errors for mongo and redis